Skip to content

Conversation

@rtyler
Copy link
Member

@rtyler rtyler commented Sep 20, 2025

Supply chain attacks are on my mind lately for no good reason whatsoever, so
taking some time to purge unnecessary dependencies from our tree where I can
find it.

@rtyler rtyler requested review from ion-elgreco and roeap September 20, 2025 21:58
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Sep 20, 2025
@codecov
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 89.37500% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.09%. Comparing base (38d8d7a) to head (795f8cd).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...rates/core/src/operations/update_field_metadata.rs 0.00% 7 Missing ⚠️
crates/core/src/kernel/models/fields.rs 88.00% 6 Missing ⚠️
python/src/schema.rs 0.00% 4 Missing ⚠️
crates/core/src/kernel/arrow/engine_ext.rs 96.93% 1 Missing and 2 partials ⚠️
crates/core/src/kernel/models/actions.rs 0.00% 3 Missing ⚠️
crates/core/src/kernel/snapshot/mod.rs 89.28% 2 Missing and 1 partial ⚠️
crates/core/src/table/state.rs 0.00% 0 Missing and 2 partials ⚠️
crates/core/src/delta_datafusion/table_provider.rs 50.00% 0 Missing and 1 partial ⚠️
crates/core/src/kernel/schema/cast/merge_schema.rs 50.00% 0 Missing and 1 partial ⚠️
crates/core/src/operations/add_column.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3773      +/-   ##
==========================================
+ Coverage   76.06%   76.09%   +0.02%     
==========================================
  Files         145      145              
  Lines       45025    45117      +92     
  Branches    45025    45117      +92     
==========================================
+ Hits        34249    34330      +81     
- Misses       9094     9098       +4     
- Partials     1682     1689       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rtyler rtyler force-pushed the chore/less-warnings-is-nice branch from 8d6ceeb to c046b72 Compare September 21, 2025 14:50
@github-actions github-actions bot added the binding/python Issues for the Python package label Sep 21, 2025
@rtyler rtyler force-pushed the chore/less-warnings-is-nice branch 3 times, most recently from 2ac42d6 to b1c7357 Compare September 21, 2025 15:38
@rtyler rtyler changed the title chore: remove more unnecessary dependencies and warnings chore: upgrade to delta-kernel-rs 0.16.0 and remove more dependencies Sep 21, 2025
@rtyler rtyler marked this pull request as ready for review September 22, 2025 12:50
@rtyler rtyler requested a review from hntd187 as a code owner September 22, 2025 12:50
@rtyler rtyler enabled auto-merge (rebase) September 22, 2025 12:51
@rtyler rtyler force-pushed the chore/less-warnings-is-nice branch from e60e8ae to 827c3de Compare September 22, 2025 13:04
There were a number of symbols only used during `datafusion` usage

Signed-off-by: R. Tyler Croy <[email protected]>
This dependency comes from the chrono org, so I kinda trust it, but it's
not something we should have in the hierarchy unless it's being used

Signed-off-by: R. Tyler Croy <[email protected]>
The StructType public API change was pretty invasive, oof.

Fixes delta-io#3774

Signed-off-by: R. Tyler Croy <[email protected]>
The kernel level is doing this validation now

Signed-off-by: R. Tyler Croy <[email protected]>
@rtyler rtyler force-pushed the chore/less-warnings-is-nice branch from 827c3de to d47e7dc Compare September 23, 2025 13:42
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rtyler rtyler merged commit 9b35849 into delta-io:main Sep 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants