fix: update storage_options when using DeltaTable in write_deltalake #2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilsIrl
requested review from
fvaleye,
ion-elgreco,
roeap and
wjones127
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
NilsIrl
changed the title
NilsIrl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
==========================================
+ Coverage 72.49% 72.51% +0.01%
==========================================
Files 131 131
Lines 40421 40421
Branches 40421 40421
==========================================
+ Hits 29303 29310 +7
- Misses 9238 9239 +1
+ Partials 1880 1872 -8 ☔ View full report in Codecov by Sentry. |
|
@NilsIrl can you add a test please |
|
Hi, sorry I don't have the bandwidth to look into that at the moment. |
|
This won't work with the recent changes anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous code was erroneous and if a DeltaTable instance was kept for too long its credentials could expire with no way of updating them.