Skip to content

Conversation

@rtyler
Copy link
Member

@rtyler rtyler commented Oct 8, 2024

This change addresses some of the problems tacked onto #2893 but does not address the concern with ECS specifically. It does however improve the handling of storage_options since the improved credential provider code was introduced

This change addresses some of the problems tacked onto delta-io#2893 but does
not address the concern with ECS specifically. It does however improve
the handling of `storage_options` since the improved credential
provider code was introduced
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 8, 2024
@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (f9436cb) to head (a55115c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/aws/src/credentials.rs 90.69% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
+ Coverage   72.40%   72.42%   +0.02%     
==========================================
  Files         131      131              
  Lines       40505    40545      +40     
  Branches    40505    40545      +40     
==========================================
+ Hits        29326    29366      +40     
+ Misses       9291     9290       -1     
- Partials     1888     1889       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler mentioned this pull request Oct 8, 2024
@rtyler rtyler marked this pull request as ready for review October 8, 2024 14:34
@rtyler rtyler enabled auto-merge October 8, 2024 14:35
@rtyler rtyler added this pull request to the merge queue Oct 8, 2024
Merged via the queue into delta-io:main with commit ef4e4a3 Oct 8, 2024
21 checks passed
@rtyler rtyler deleted the aws-better-storage-options-support-2893 branch October 8, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants