-
Couldn't load subscription status.
- Fork 537
fix: attempt to workaround problems reading actions as empty rather than null #3045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3045 +/- ##
==========================================
- Coverage 72.68% 72.62% -0.06%
==========================================
Files 129 129
Lines 41462 41509 +47
Branches 41462 41509 +47
==========================================
+ Hits 30137 30147 +10
- Misses 9376 9415 +39
+ Partials 1949 1947 -2 ☔ View full report in Codecov by Sentry. |
54487ea to
09f1376
Compare
…ilure(s) See delta-io#3030 Signed-off-by: R. Tyler Croy <[email protected]>
The root cause remains elusive but with the recent arrow upgrade the nullable deletionVector struct, which contains non-nullable fields, is being read out as "empty" in the default case rather than as null. This causes the "seen" code in log replay to fail to correctly identify files which should be marked as removed when computing the state of the snapshot. This change introduces another workaround that I am still not thrilled about 😒 Fixes delta-io#3030 Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
09f1376 to
48ba19f
Compare
See #3030