feat: added a check for gc code to run #3419
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
JustinRush80
changed the title
ion-elgreco
reviewed
May 8, 2025
Comment on lines
454
to
458
| let generated_col_expressions = this | ||
| .snapshot | ||
| .as_ref() | ||
| .map(|v| v.schema().get_generated_columns().unwrap_or_default()) | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
You can do snapshot.schema() now since you already checked existence :)
There was a problem hiding this comment.
Ahh thank you for the catch!
| let (source, missing_generated_columns) = | ||
| add_missing_generated_columns(source.clone(), &generated_col_expressions)?; | ||
|
|
||
| source_with_gc = Some(source); |
There was a problem hiding this comment.
small nit, but we can do same as you did in the write mod, just use a mut source
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
… into fix/valid_gc
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
Signed-off-by: JustinRush80 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a validation check that only runs if generated columns feature is enabled in the tablefeatures or writer version 5 is enabled
Related Issue(s)
Documentation