Skip to content

feat: implement object store that caches to disk #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+614 −5

feat: implement object store that caches to disk

3643c91
Select commit
Loading
Failed to load commit list.
Open

feat: implement object store that caches to disk #3439

feat: implement object store that caches to disk
3643c91
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 31, 2025 in 0s

14.57% (-59.94%) compared to 6a4f249

View this Pull Request on Codecov

14.57% (-59.94%) compared to 6a4f249

Details

Codecov Report

❌ Patch coverage is 5.48780% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.57%. Comparing base (6a4f249) to head (3643c91).
⚠️ Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/logstore/storage/file_cache.rs 0.00% 145 Missing ⚠️
crates/core/src/logstore/config.rs 52.94% 6 Missing and 2 partials ⚠️
crates/core/src/logstore/mod.rs 0.00% 0 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (6a4f249) and HEAD (3643c91). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (6a4f249) HEAD (3643c91)
6 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3439       +/-   ##
===========================================
- Coverage   74.50%   14.57%   -59.94%     
===========================================
  Files         146       71       -75     
  Lines       44876    12273    -32603     
  Branches    44876    12273    -32603     
===========================================
- Hits        33437     1789    -31648     
- Misses       9248    10270     +1022     
+ Partials     2191      214     -1977

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov