Skip to content

Conversation

@gtrawinski
Copy link
Contributor

Description

The description of the main changes of your pull request

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label May 29, 2025
@gtrawinski gtrawinski closed this May 29, 2025
@gtrawinski gtrawinski deleted the REL-1080393-merge-state-reuse branch May 29, 2025 09:56
@gtrawinski gtrawinski restored the REL-1080393-merge-state-reuse branch May 29, 2025 09:56
@gtrawinski gtrawinski deleted the REL-1080393-merge-state-reuse branch May 29, 2025 09:57
@gtrawinski gtrawinski restored the REL-1080393-merge-state-reuse branch May 29, 2025 10:02
@gtrawinski gtrawinski reopened this May 29, 2025
@gtrawinski gtrawinski force-pushed the REL-1080393-merge-state-reuse branch from 3d85f81 to ae5b2cf Compare May 29, 2025 10:07
@rtyler
Copy link
Member

rtyler commented May 29, 2025

👋 seems like a pretty straightforward change, can you share more details on what issue this resolves?

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.12%. Comparing base (48cf336) to head (767a87a).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
+ Coverage   71.36%   73.12%   +1.76%     
==========================================
  Files         149      149              
  Lines       44919    44885      -34     
  Branches    44919    44885      -34     
==========================================
+ Hits        32055    32824     +769     
+ Misses      10788     9925     -863     
- Partials     2076     2136      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gtrawinski
Copy link
Contributor Author

👋 seems like a pretty straightforward change, can you share more details on what issue this resolves?

Sure - the SessionState that's provided in the argument of the method is not being used in the code. That change allows to use the fields from provided SessionState and maintain the consistency. It's similarly implemented for the update command.

@gtrawinski gtrawinski closed this Jun 2, 2025
@gtrawinski gtrawinski deleted the REL-1080393-merge-state-reuse branch June 2, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants