Skip to content

feat: if the user asks not to load files, make EagerSnapshot _never_ load files #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

chore: return a bool on snapshot update to indicate whether files wer…

53ba1e8
Select commit
Loading
Failed to load commit list.
Draft

feat: if the user asks not to load files, make EagerSnapshot _never_ load files #3580

chore: return a bool on snapshot update to indicate whether files wer…
53ba1e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 14, 2025 in 0s

74.48% (-0.03%) compared to 0372bff

View this Pull Request on Codecov

74.48% (-0.03%) compared to 0372bff

Details

Codecov Report

Attention: Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.48%. Comparing base (0372bff) to head (53ba1e8).

Files with missing lines Patch % Lines
crates/core/src/kernel/snapshot/mod.rs 86.04% 5 Missing and 1 partial ⚠️
python/src/lib.rs 0.00% 3 Missing ⚠️
crates/core/src/lib.rs 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3580      +/-   ##
==========================================
- Coverage   74.51%   74.48%   -0.03%     
==========================================
  Files         146      146              
  Lines       44875    44898      +23     
  Branches    44875    44898      +23     
==========================================
+ Hits        33437    33441       +4     
- Misses       9245     9250       +5     
- Partials     2193     2207      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov