feat(url): use Url in Rust for accessing to DeltaTable, use only string-based api in Python #3707

fvaleye · 2025-08-25T14:02:28Z

Description

Use the URL crate in Rust for accessing the DeltaTable. Use only the string-based API in Python.

Rust APIs now take url::Url for opening/creating tables.
Python keeps str at the boundary and parses to URL immediately.
String-based Rust helpers still exist and are marked deprecated (for migration).

Related Issue(s)

closes Adopt url::Url based interfaces for referring to tables #3615

Documentation

Use URL in Rust instead of using &str
Keep &str for the Python binding with helper methods
Keep backward compatibility by making the URI deprecated.

Side notes: 💚
@rtyler, I started contributing to delta-rs with my first PR regarding URI.
So, as a "comeback", I'm taking this opportunity to improve it 😄

github-actions · 2025-08-25T14:02:50Z

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

codecov · 2025-08-25T14:04:57Z

Codecov Report

❌ Patch coverage is 74.57627% with 120 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.36%. Comparing base (437718b) to head (1159c4b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/core/src/table/builder.rs	55.81%	11 Missing and 8 partials ⚠️
python/src/lib.rs	0.00%	19 Missing ⚠️
crates/core/src/operations/mod.rs	22.22%	13 Missing and 1 partial ⚠️
crates/test/src/read.rs	0.00%	0 Missing and 10 partials ⚠️
crates/core/src/protocol/checkpoints.rs	45.45%	5 Missing and 1 partial ⚠️
crates/core/src/protocol/mod.rs	71.42%	6 Missing ⚠️
crates/core/src/kernel/snapshot/mod.rs	28.57%	0 Missing and 5 partials ⚠️
crates/core/src/test_utils/mod.rs	28.57%	3 Missing and 2 partials ⚠️
crates/catalog-unity/src/datafusion.rs	0.00%	4 Missing ⚠️
python/src/filesystem.rs	0.00%	4 Missing ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3707      +/-   ##
==========================================
- Coverage   75.38%   75.36%   -0.02%     
==========================================
  Files         145      145              
  Lines       43690    43955     +265     
  Branches    43690    43955     +265     
==========================================
+ Hits        32935    33127     +192     
- Misses       9161     9222      +61     
- Partials     1594     1606      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rtyler · 2025-08-25T14:23:22Z

@fvaleye This has some conflicts after some concurrent changes were happening by @roeap , I can resolve these conflicts and force push if that's okay with you

fvaleye · 2025-08-25T14:24:32Z

@fvaleye This has some conflicts after some concurrent changes were happening by @roeap , I can resolve these conflicts and force push if that's okay with you

No worries @rtyler, I'm on it 👍

roeap

That must have been fun tucking about every test that opens a table :).

Thanks for taking care of this.

crates/catalog-unity/src/datafusion.rs

crates/core/src/test_utils/mod.rs

crates/core/src/table/builder.rs

crates/core/src/writer/record_batch.rs

roeap · 2025-08-25T14:39:59Z

crates/core/src/lib.rs

 /// Will fail fast if specified `table_uri` is a local path but doesn't exist.
-pub async fn open_table(table_uri: impl AsRef<str>) -> Result<DeltaTable, DeltaTableError> {
-    let table = DeltaTableBuilder::from_valid_uri(table_uri)?.load().await?;
+pub async fn open_table(table_uri: Url) -> Result<DeltaTable, DeltaTableError> {


Just thinking out loud .. with object store we do have reqwest in our dependency tree anyways, which exposes an IntoUrl trait ... however then we would have a coupling with the requwest version as we now expose its types, so not worth it.

Let me put a nice cargo tree 😄

either → … → reqwest v0.12.15 delta_kernel v0.14.0 → reqwest v0.12.15 deltalake-core v0.28.0 → reqwest v0.12.15 deltalake-lakefs v0.11.0 → reqwest v0.12.15

I'm still searching, but idk where we could use the IntoUrl... should we safely deprecate it?

python/src/filesystem.rs

fvaleye · 2025-08-25T15:36:45Z

That must have been fun tucking about every test that opens a table :).

Fun? I want to know your hobbies @roeap 🤣
It was more of a pain to "play" with the different paths in the codebase, as I started working on a cloning feature...

fvaleye · 2025-09-01T08:19:43Z

All good @rtyler @roeap 🚀

…ng-based api in Python Signed-off-by: Florian Valeye <[email protected]>

roeap

LGTM!

Signed-off-by: R. Tyler Croy <[email protected]>

Copilot AI review requested due to automatic review settings August 25, 2025 14:02

fvaleye added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Aug 25, 2025

fvaleye requested review from hntd187, ion-elgreco, roeap and rtyler as code owners August 25, 2025 14:02

github-actions bot added the delta-inspect label Aug 25, 2025

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch from 249d970 to 045bad4 Compare August 25, 2025 14:02

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch from 045bad4 to 2410c54 Compare August 25, 2025 14:06

rtyler self-assigned this Aug 25, 2025

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch from 2410c54 to 9f19896 Compare August 25, 2025 14:08

fvaleye changed the title ~~feature(url): use Url in Rust for accessing to DeltaTable, use only string-based api in Python~~ feat(url): use Url in Rust for accessing to DeltaTable, use only string-based api in Python Aug 25, 2025

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch from 0fb5b46 to 8a4c58b Compare August 25, 2025 14:17

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch 2 times, most recently from 9e14c5f to 9b56090 Compare August 25, 2025 14:29

roeap previously approved these changes Aug 25, 2025

View reviewed changes

fvaleye dismissed roeap’s stale review via bff8327 August 25, 2025 15:12

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch 2 times, most recently from 40bfca3 to c7c31a5 Compare August 25, 2025 15:19

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch 5 times, most recently from 8e2d4f5 to 3d17fdd Compare August 25, 2025 15:46

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch 3 times, most recently from 79e8aad to 95b1fcd Compare September 1, 2025 08:02

rtyler previously approved these changes Sep 1, 2025

View reviewed changes

rtyler disabled auto-merge September 1, 2025 14:14

rtyler enabled auto-merge (rebase) September 1, 2025 14:14

rtyler closed this Sep 1, 2025

auto-merge was automatically disabled September 1, 2025 14:14
Pull request was closed

rtyler reopened this Sep 1, 2025

rtyler enabled auto-merge (rebase) September 1, 2025 14:14

auto-merge was automatically disabled September 1, 2025 14:34
Rebase failed

rtyler dismissed their stale review via 72548b0 September 1, 2025 15:00

rtyler force-pushed the feature/use-url-in-for-referring-tables branch from 95b1fcd to 72548b0 Compare September 1, 2025 15:00

rtyler enabled auto-merge (rebase) September 1, 2025 15:00

rtyler force-pushed the feature/use-url-in-for-referring-tables branch from 72548b0 to 5b2a309 Compare September 2, 2025 00:02

fvaleye force-pushed the feature/use-url-in-for-referring-tables branch 3 times, most recently from 4fc2878 to c1260ce Compare September 2, 2025 07:50

rtyler previously approved these changes Sep 2, 2025

View reviewed changes

auto-merge was automatically disabled September 2, 2025 13:27
Rebase failed

feat(url): use Url in Rust for accessing to DeltaTable, use only stri…

d5195c1

…ng-based api in Python Signed-off-by: Florian Valeye <[email protected]>

rtyler dismissed their stale review via d5195c1 September 2, 2025 13:37

rtyler force-pushed the feature/use-url-in-for-referring-tables branch from c1260ce to d5195c1 Compare September 2, 2025 13:37

rtyler enabled auto-merge (rebase) September 2, 2025 13:37

roeap previously approved these changes Sep 2, 2025

View reviewed changes

chore: minor conflict fixes to green up the build again

1159c4b

Signed-off-by: R. Tyler Croy <[email protected]>

rtyler dismissed roeap’s stale review via 1159c4b September 2, 2025 13:45

roeap approved these changes Sep 2, 2025

View reviewed changes

rtyler merged commit b941b6c into delta-io:main Sep 2, 2025
28 of 29 checks passed

Uh oh!

feat(url): use Url in Rust for accessing to DeltaTable, use only string-based api in Python #3707

feat(url): use Url in Rust for accessing to DeltaTable, use only string-based api in Python #3707

Uh oh!

Conversation

fvaleye commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Documentation

Uh oh!

github-actions bot commented Aug 25, 2025

Uh oh!

codecov bot commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rtyler commented Aug 25, 2025

Uh oh!

fvaleye commented Aug 25, 2025

Uh oh!

roeap left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

roeap Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

fvaleye Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fvaleye commented Aug 25, 2025

Uh oh!

fvaleye commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roeap left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fvaleye commented Aug 25, 2025 •

edited

Loading

codecov bot commented Aug 25, 2025 •

edited

Loading

fvaleye Aug 25, 2025 •

edited

Loading

fvaleye commented Sep 1, 2025 •

edited

Loading