fix: better error handles in unity client #3752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
…d response code Signed-off-by: Stephen Carman <[email protected]>
hntd187
force-pushed
the
check-error-codes
branch
from
661758d to
785f195
Compare
hntd187
changed the title
…tead of just the status code Signed-off-by: Stephen Carman <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
==========================================
+ Coverage 75.54% 75.63% +0.09%
==========================================
Files 145 145
Lines 44431 44465 +34
Branches 44431 44465 +34
==========================================
+ Hits 33564 33631 +67
+ Misses 9224 9188 -36
- Partials 1643 1646 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hntd187
changed the title
ion-elgreco
approved these changes
Sep 11, 2025
fvaleye
pushed a commit
to fvaleye/delta-rs
that referenced
this pull request
Sep 12, 2025
# Description Just generally check for non-200 response codes and give them back instead of a "token missing" error which is not helpful. # Related Issue(s) Fixes delta-io#3739 --------- Signed-off-by: Stephen Carman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just generally check for non-200 response codes and give them back instead of a "token missing" error which is not helpful.
Related Issue(s)
Fixes #3739