-
Couldn't load subscription status.
- Fork 537
feat: allow OptimizeBuilder to accept SessionConfig for finer-grained control of execution #3763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow OptimizeBuilder to accept SessionConfig for finer-grained control of execution #3763
Conversation
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
d28c2e1 to
ce1f9d4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3763 +/- ##
==========================================
- Coverage 75.70% 75.69% -0.01%
==========================================
Files 145 145
Lines 44719 44731 +12
Branches 44719 44731 +12
==========================================
+ Hits 33854 33860 +6
- Misses 9193 9199 +6
Partials 1672 1672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @rtyler 👋, If you would like minimal changes:
For going broader across the codebase, you could adapt |
… of execution After some debate decided that SessionConfig is sufficient to pull through rather than SessionContext. Due to the wacky nature of some of our code-paths in this operation, the signatures of a number of internal functions had to change to allow SessionConfig to be pulled all the way down into the ZOrderExecContext Fixes delta-io#3751 Signed-off-by: R. Tyler Croy <[email protected]>
ce1f9d4 to
ba976d9
Compare
|
@fvaleye I have taken some time to cnosider the suggestion. I am reluctant to add environmental configuration loading into delta-rs from a general standpoint. I think that can lead to surprising behavior for end-users who are not expecting it. I feel that the builder pattern does give end-users the ability to do that if I am not thrilled with how invesaive adding this has to be, but I don't have a |
Fair point! The builder's new option is the more convenient approach. |
After some debate decided that SessionConfig is sufficient to pull
through rather than SessionContext. Due to the wacky nature of some of
our code-paths in this operation, the signatures of a number of internal
functions had to change to allow SessionConfig to be pulled all the way
down into the ZOrderExecContext
Fixes #3751