fix: somehow the right test value didn't make it into the pr #3788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check that caught this wasn't apparently "required" when I had refactored our repo rules a month or so ago. I had also made this change locally, there might even be video evidence of it 😄 but I must not have correctly pushed it Signed-off-by: R. Tyler Croy <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3788 +/- ##
==========================================
- Coverage 76.09% 76.08% -0.01%
==========================================
Files 145 145
Lines 45117 45117
Branches 45117 45117
==========================================
- Hits 34330 34328 -2
- Misses 9098 9101 +3
+ Partials 1689 1688 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fvaleye
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check that caught this wasn't apparently "required" when I had refactored our repo rules a month or so ago.
I had also made this change locally, there might even be video evidence of it 😄 but I must not have correctly pushed it