Skip to content

Conversation

@fvaleye
Copy link
Collaborator

@fvaleye fvaleye commented Sep 29, 2025

Description

Add a step to clean the cache entries of GitHub actions:

  • Integrate cleanup-cache job into dev_pr.yml workflow
  • Delete up to 100 cache entries per closed PR targeting main
  • Prevent cache thrashing with proper error handling and logging

Documentation

@fvaleye fvaleye requested a review from rtyler as a code owner September 29, 2025 09:02
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.10%. Comparing base (ed4e244) to head (d3dfdab).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3793   +/-   ##
=======================================
  Coverage   76.10%   76.10%           
=======================================
  Files         145      145           
  Lines       45200    45200           
  Branches    45200    45200           
=======================================
+ Hits        34399    34400    +1     
  Misses       9105     9105           
+ Partials     1696     1695    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fvaleye fvaleye force-pushed the fix/remove-gh-cache-on-main branch from 34e98c8 to ffe522c Compare September 29, 2025 09:08
- edited
- synchronize
- reopened
- closed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are other types of targets in this list, I think this is going to purge the caches for any pull request action rather than just "closed".

I don't think there's a downside to creating a separate workflow file just for the cleanup and then that can uave

on:
  pull_request_target:
    - closed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks @rtyler

@fvaleye fvaleye force-pushed the fix/remove-gh-cache-on-main branch from ffe522c to f2db2c8 Compare September 30, 2025 07:11
@rtyler rtyler enabled auto-merge (rebase) September 30, 2025 13:17
@fvaleye fvaleye requested a review from rtyler September 30, 2025 16:28
@fvaleye fvaleye force-pushed the fix/remove-gh-cache-on-main branch from 13c2f34 to d3dfdab Compare September 30, 2025 16:35
auto-merge was automatically disabled October 1, 2025 12:56

Rebase failed

@rtyler rtyler merged commit 51d04ce into delta-io:main Oct 1, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants