Skip to content

Conversation

@ion-elgreco
Copy link
Collaborator

@ion-elgreco ion-elgreco commented Oct 3, 2025

Description

When creating a DeltaTable with new_from_state we should persist the load_config from the state also on the DeltaTable Struct, in reality this has no true effect because we never hit a code path of using the config from DeltaTable after we have Some(DeltaTableState) since we only look at the LoadConfig within the snapshot. The config on the DeltaTable struct is only used when creating the snapshot and then it's passed through it. After we have a snapshot, the config is only used from within there.

But this is more correct so lets prevent footguns in the future if we do for some reason look at the DeltaTable struct for the config.

@corwinjoy

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 3, 2025
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.05%. Comparing base (cff42fc) to head (908c320).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3805       +/-   ##
===========================================
+ Coverage   18.79%   76.05%   +57.26%     
===========================================
  Files          74      145       +71     
  Lines       12035    45274    +33239     
  Branches    12035    45274    +33239     
===========================================
+ Hits         2262    34435    +32173     
+ Misses       9587     9148      -439     
- Partials      186     1691     +1505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-elgreco ion-elgreco enabled auto-merge (squash) October 3, 2025 08:26
@ion-elgreco ion-elgreco merged commit fb73c6f into delta-io:main Oct 3, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants