fix: maintaining load config from state #3805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a DeltaTable with new_from_state we should persist the
load_configfrom the state also on the DeltaTable Struct, in reality this has no true effect because we never hit a code path of using the config from DeltaTable after we haveSome(DeltaTableState)since we only look at the LoadConfig within the snapshot. The config on the DeltaTable struct is only used when creating the snapshot and then it's passed through it. After we have a snapshot, the config is only used from within there.But this is more correct so lets prevent footguns in the future if we do for some reason look at the DeltaTable struct for the config.
@corwinjoy