Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions .github/actions/setup-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ runs:
using: "composite"

steps:
- name: checkout
uses: actions/checkout@v4

Comment on lines -19 to -21
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to checkout the code before we can use local actions. so this must have been unused anyhow.

- name: Install uv
uses: astral-sh/setup-uv@v3

Expand All @@ -27,14 +24,13 @@ runs:
with:
python-version: ${{ inputs.python-version }}

- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
with:
profile: default
toolchain: ${{ inputs.rust-toolchain }}
override: true
components: rustfmt, clippy
- name: Setup sccache
uses: mozilla-actions/[email protected]

- uses: Swatinem/rust-cache@v2
- name: Setup Rust toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions-rs/toolchain seems unmaintained albeit still widely used. This action is maintained and has the additional benefit of also setting up Swatinem/rust-cache. My assumtion beeing that they spend much more time thinging about how than I am hoping to invest 😆.

with:
cache-targets: false
toolchain: ${{ inputs.rust-toolchain }}
cache: true
# if we ever get rid of all the clippy warnings, we can remove this line
rustflags: ""
Loading
Loading