Skip to content

Conversation

@roeap
Copy link
Collaborator

@roeap roeap commented Oct 4, 2025

Description

Another round of cleanup after the kernel migration.

In this PR we extract the tombstone data from the log data stream via a kernel evaluator rather than maintaining our own extraction code. We also expose tombstones via the new TombstoneView analogous to accessing the logical files from the log.

While we are at it, we also normalise on streams for accessing log data.

closes #3808

@roeap roeap requested review from hntd187 and rtyler as code owners October 4, 2025 15:56
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 4, 2025
@roeap roeap requested a review from ion-elgreco October 4, 2025 15:56
@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 84.73282% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.26%. Comparing base (b8e2170) to head (b953f56).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/test_utils/factories/actions.rs 0.00% 9 Missing ⚠️
crates/core/src/table/state.rs 37.50% 5 Missing ⚠️
crates/core/src/kernel/snapshot/mod.rs 91.30% 0 Missing and 2 partials ⚠️
crates/core/src/kernel/snapshot/replay.rs 86.66% 0 Missing and 2 partials ⚠️
crates/test/src/read.rs 92.85% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3809      +/-   ##
==========================================
+ Coverage   74.23%   74.26%   +0.02%     
==========================================
  Files         145      145              
  Lines       39522    39396     -126     
  Branches    39522    39396     -126     
==========================================
- Hits        29341    29259      -82     
+ Misses       8767     8736      -31     
+ Partials     1414     1401      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ion-elgreco
ion-elgreco previously approved these changes Oct 4, 2025
@roeap roeap enabled auto-merge (squash) October 4, 2025 17:06
@github-actions github-actions bot added the binding/python Issues for the Python package label Oct 4, 2025
@roeap roeap linked an issue Oct 4, 2025 that may be closed by this pull request
@roeap roeap requested a review from ion-elgreco October 5, 2025 08:12
@roeap roeap merged commit 2707e53 into delta-io:main Oct 5, 2025
38 of 39 checks passed
@roeap roeap deleted the refactor/more-expressions branch October 5, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use kernel expressions for extracting data from Record batches. Kernel error when vacuuming table

2 participants