Skip to content

Conversation

@roeap
Copy link
Collaborator

@roeap roeap commented Oct 5, 2025

Description

The vacuum operations was the last one still using DeltaTableState. Now that we have updated tombstone access, we can also migrate this one to use EagerSnapshot.

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Oct 5, 2025
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.28%. Comparing base (2707e53) to head (07abe3b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/vacuum.rs 82.47% 1 Missing and 16 partials ⚠️
python/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3812      +/-   ##
==========================================
- Coverage   74.28%   74.28%   -0.01%     
==========================================
  Files         145      145              
  Lines       39418    39419       +1     
  Branches    39418    39419       +1     
==========================================
- Hits        29283    29281       -2     
- Misses       8732     8736       +4     
+ Partials     1403     1402       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap enabled auto-merge (squash) October 5, 2025 09:18
@roeap roeap linked an issue Oct 5, 2025 that may be closed by this pull request
@roeap roeap changed the title refactor: use EagerSnapshot in vacuum operation #3784 refactor: use EagerSnapshot in vacuum operation Oct 5, 2025
@roeap roeap merged commit c29d637 into delta-io:main Oct 5, 2025
40 of 41 checks passed
@ion-elgreco
Copy link
Collaborator

@roeap it's getting difficult to keep up haha

@roeap roeap deleted the refactor/eager-vacuum branch October 5, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consistently use EagerSnapshot in datafusion module.

2 participants