Skip to content

Conversation

@roeap
Copy link
Collaborator

@roeap roeap commented Oct 5, 2025

Description

We maintain duplicate versions of the session_state_from_session function to downcast a datafusion Session to SessionState. By now we can omit this however and just update a few apis to allow for the more permissible Session.

part-of #3799

@roeap roeap requested a review from ion-elgreco October 5, 2025 17:29
@roeap roeap requested review from hntd187 and rtyler as code owners October 5, 2025 17:29
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 5, 2025
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (aad4499) to head (c00e257).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
+ Coverage   74.37%   74.38%   +0.01%     
==========================================
  Files         145      145              
  Lines       39482    39467      -15     
  Branches    39482    39467      -15     
==========================================
- Hits        29365    29359       -6     
+ Misses       8719     8711       -8     
+ Partials     1398     1397       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap enabled auto-merge (squash) October 5, 2025 17:31
@roeap roeap force-pushed the refactor/use-session branch from 8146006 to c00e257 Compare October 5, 2025 17:43
@roeap roeap merged commit e2081e0 into delta-io:main Oct 5, 2025
24 of 26 checks passed
@roeap roeap deleted the refactor/use-session branch October 5, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants