Skip to content

Conversation

@roeap
Copy link
Collaborator

@roeap roeap commented Oct 5, 2025

Description

Just moving some code around in the datafusion module. Specifically the find_files function and its dependencies are now in a dedicated module. There we still make the heaviest use of Add actions and contains significant complexity, so i wanted to isolate it for upcoming refactors.

@roeap roeap requested review from hntd187 and rtyler as code owners October 5, 2025 18:36
@roeap roeap enabled auto-merge (squash) October 5, 2025 18:36
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 5, 2025
@github-actions
Copy link

github-actions bot commented Oct 5, 2025

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@roeap roeap requested a review from ion-elgreco October 5, 2025 18:36
@roeap roeap changed the title refactors: move find_files into dedicated mod refactor: move find_files into dedicated mod Oct 5, 2025
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 80.61224% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.37%. Comparing base (3939373) to head (62b2fb0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/find_files.rs 81.06% 7 Missing and 25 partials ⚠️
crates/core/src/operations/merge/filter.rs 72.22% 0 Missing and 5 partials ⚠️
crates/core/src/operations/load.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3815      +/-   ##
==========================================
- Coverage   74.40%   74.37%   -0.03%     
==========================================
  Files         145      146       +1     
  Lines       39492    39457      -35     
  Branches    39492    39457      -35     
==========================================
- Hits        29383    29346      -37     
- Misses       8712     8714       +2     
  Partials     1397     1397              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap merged commit 9bd1b8e into delta-io:main Oct 5, 2025
27 of 28 checks passed
@roeap roeap deleted the refactor/df-mod branch October 5, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants