Skip to content

Conversation

@roeap
Copy link
Collaborator

@roeap roeap commented Oct 7, 2025

Description

In many places we require the arrow schema of a snapshot. As such we replicate converting schemas in many places. In this PR we track a reference to an arrow schema on our innermost snapshot and start using it in some places.

We also now expose the kernel schema as an arc to better alogn with how delta kernel and datafusion expose schemas.

part-of: #3733

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Oct 7, 2025
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 81.13208% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.38%. Comparing base (d5402ee) to head (4bc9c40).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/mod.rs 71.11% 9 Missing and 4 partials ⚠️
python/src/schema.rs 0.00% 5 Missing ⚠️
crates/core/src/kernel/snapshot/mod.rs 90.00% 0 Missing and 3 partials ⚠️
python/src/lib.rs 0.00% 3 Missing ⚠️
crates/core/src/delta_datafusion/cdf/scan.rs 0.00% 1 Missing ⚠️
crates/core/src/operations/add_column.rs 0.00% 1 Missing ⚠️
crates/core/src/operations/load.rs 0.00% 0 Missing and 1 partial ⚠️
crates/core/src/operations/merge/mod.rs 94.44% 0 Missing and 1 partial ⚠️
crates/core/src/operations/optimize.rs 50.00% 0 Missing and 1 partial ⚠️
python/src/query.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3822      +/-   ##
==========================================
+ Coverage   74.34%   74.38%   +0.04%     
==========================================
  Files         147      147              
  Lines       39517    39522       +5     
  Branches    39517    39522       +5     
==========================================
+ Hits        29377    29397      +20     
+ Misses       8740     8739       -1     
+ Partials     1400     1386      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap force-pushed the feat/arrow-schema branch from 8f946a0 to 14092bf Compare October 7, 2025 08:42
@roeap roeap force-pushed the feat/arrow-schema branch from 14092bf to 8582ca8 Compare October 7, 2025 08:43
ion-elgreco
ion-elgreco previously approved these changes Oct 7, 2025
@roeap
Copy link
Collaborator Author

roeap commented Oct 7, 2025

@ion-elgreco - there was some confusion with the arrow_schema field on the datafusion mixin. this is fixed now and we also made the schema methods on the mixin infallible.

mind stamping again? 😄

@roeap roeap enabled auto-merge (squash) October 7, 2025 10:29
@roeap roeap requested a review from ion-elgreco October 7, 2025 10:43
@roeap roeap merged commit 52e6fa2 into delta-io:main Oct 7, 2025
29 checks passed
@roeap roeap deleted the feat/arrow-schema branch October 7, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants