Skip to content

refactor(bench): remove baseline while keeping the json_parsing benchmark #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2025
Merged

refactor(bench): remove baseline while keeping the json_parsing benchmark #3838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 3 additions & 56 deletions crates/core/benches/json_parsing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
use bytes::Bytes;
use criterion::{black_box, criterion_group, criterion_main, Criterion, Throughput};
use std::io::{BufRead, BufReader, Cursor};
use std::time::Duration;
use tokio::runtime::Runtime;

use deltalake_core::kernel::Action;
use deltalake_core::logstore::get_actions;
use deltalake_core::DeltaTableError;

fn generate_commit_log_complex(
num_actions: usize,
Expand Down Expand Up @@ -50,29 +47,6 @@ fn generate_commit_log_complex(
Bytes::from(log_lines.join("\n"))
}

// Baseline implementation for comparison
// TODO: this is the version of the main branch for performance comparison
// Remove it after merging the PR
async fn get_actions_baseline(
version: i64,
commit_log_bytes: Bytes,
) -> Result<Vec<Action>, DeltaTableError> {
let reader = BufReader::new(Cursor::new(commit_log_bytes));

let mut actions = Vec::new();
for re_line in reader.lines() {
let line = re_line?;
let lstr = line.as_str();
let action = serde_json::from_str(lstr).map_err(|e| DeltaTableError::InvalidJsonLog {
json_err: e,
line,
version,
})?;
actions.push(action);
}
Ok(actions)
}

fn bench_simple_actions(c: &mut Criterion) {
let rt = Runtime::new().unwrap();
let mut group = c.benchmark_group("simple_actions_1000");
Expand All @@ -82,16 +56,7 @@ fn bench_simple_actions(c: &mut Criterion) {

let commit_log = generate_commit_log_complex(1000, false, false, false);

group.bench_function("baseline", |b| {
b.iter(|| {
rt.block_on(async {
let result = get_actions_baseline(0, commit_log.clone()).await;
black_box(result.unwrap().len())
})
});
});

group.bench_function("new version", |b| {
group.bench_function("get_actions", |b| {
b.iter(|| {
rt.block_on(async {
let result = get_actions(0, &commit_log).await;
Expand All @@ -112,16 +77,7 @@ fn bench_with_stats(c: &mut Criterion) {

let commit_log = generate_commit_log_complex(1000, true, false, false);

group.bench_function("baseline", |b| {
b.iter(|| {
rt.block_on(async {
let result = get_actions_baseline(0, commit_log.clone()).await;
black_box(result.unwrap().len())
})
});
});

group.bench_function("new version", |b| {
group.bench_function("get_actions", |b| {
b.iter(|| {
rt.block_on(async {
let result = get_actions(0, &commit_log).await;
Expand All @@ -142,16 +98,7 @@ fn bench_full_complexity(c: &mut Criterion) {

let commit_log = generate_commit_log_complex(1000, true, true, true);

group.bench_function("baseline", |b| {
b.iter(|| {
rt.block_on(async {
let result = get_actions_baseline(0, commit_log.clone()).await;
black_box(result.unwrap().len())
})
});
});

group.bench_function("new version", |b| {
group.bench_function("get_actions", |b| {
b.iter(|| {
rt.block_on(async {
let result = get_actions(0, &commit_log).await;
Expand Down
Loading