feat(bench): add new benchmarking script, harness, and profiling guide #3840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
Example profile (not very useful due to the nature of tokio/async, but wonder if there's a way around that): https://share.firefox.dev/4hcALa8 Benchmark results: |
abhiaagarwal
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3840 +/- ##
==========================================
- Coverage 73.99% 73.98% -0.02%
==========================================
Files 148 148
Lines 38904 38882 -22
Branches 38904 38882 -22
==========================================
- Hits 28788 28767 -21
Misses 8850 8850
+ Partials 1266 1265 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roeap
previously approved these changes
Oct 11, 2025
|
It seems we got rid of some dependency requirements... |
Me neither! Super fast on my M4 Pro. And I don't think so, I left it just to be consistent. It is nice to have the benchmark script as a separate binary, though |
|
don't approve yet, want to improve the harness to make sure we're only benchmarking the merge (and not the setup) |
|
Nice, much better |
ion-elgreco
reviewed
Oct 11, 2025
|
|
||
| You can generate the TPC-DS dataset yourself by downloading and compiling [the generator](https://www.tpc.org/tpc_documents_current_versions/current_specifications5.asp) | ||
| You may need to update the CFLAGS to include `-fcommon` to compile on newer versions of GCC. | ||
| This will generate a folder called `tpcds_parquet` containing many parquet files. Place it at `crates/benchmarks/data/tpcds_parquet` (or set `TPCDS_PARQUET_DIR`). Credits to [Xuanwo's Blog](https://xuanwo.io/links/2025/02/duckdb-is-the-best-tpc-data-generator/). |
There was a problem hiding this comment.
https://datafusion.apache.org/blog/2025/04/10/fastest-tpch-generator/
This one is faster than duckdb extension
ion-elgreco
requested changes
Oct 11, 2025
There was a problem hiding this comment.
Lgtm! Would only suggest using https://github.com/clflushopt/tpchgen-rs for faster generation
That's TPC-H, not TPC-DS. Looks like TPC-DS is still in progress clflushopt/tpchgen-rs#51 |
Ah didn't see that :) |
|
No worries! When the TPC-DS support gets upstreamed, we'll presumably get the ability to generate the data on-the-fly |
ion-elgreco
approved these changes
Oct 13, 2025
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
…setup Signed-off-by: Abhi Agarwal <[email protected]>
ion-elgreco
force-pushed
the
abhi/divan-allocations
branch
from
4281a86 to
74f4110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This redoes the merge-based benchmark in crates/benchmark, replacing it with
divanas a real harness combined with adding a script that can be used for profiling.Related Issue(s)
Closes #3839
Documentation
Documentation is included in the updated README