Skip to content

Conversation

@abhiaagarwal
Copy link
Contributor

@abhiaagarwal abhiaagarwal commented Oct 14, 2025

Description

Adds benchmarks based on the TPS-DS queries used in the delta-spark repository. This is definitely closer to a "datafusion benchmark" over a "delta benchmark", but it provides a decent baseline for optimization opportunities.

Related Issue(s)

Progress towards #3843

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 14, 2025
@github-actions
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@abhiaagarwal abhiaagarwal changed the title Add TPC-DS benchmarks feat(bench): add TPC-DS benchmarks Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.77%. Comparing base (f7688c4) to head (4f3cd58).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3845      +/-   ##
==========================================
- Coverage   73.78%   73.77%   -0.02%     
==========================================
  Files         151      151              
  Lines       39190    39168      -22     
  Branches    39190    39168      -22     
==========================================
- Hits        28917    28895      -22     
- Misses       8981     8983       +2     
+ Partials     1292     1290       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

roeap
roeap previously approved these changes Oct 17, 2025
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @abhiaagarwal!

Read through the code and looks great. Really stepping up the benchmarking game here!

There are a few minor CI failures to fix, but we can merge otherwise.

One question that came up, especially considering @alexwilcoxson-rel latest PR. Is there a way we can track additional metrics we collect during query execution as benchmarking results? I.e. teacking how well we do file skipping / reading so files skipped or bytes read ...

rtyler
rtyler previously approved these changes Oct 18, 2025
@abhiaagarwal abhiaagarwal dismissed stale reviews from rtyler and roeap via 75c8461 October 18, 2025 23:24
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
@abhiaagarwal
Copy link
Contributor Author

Awesome @abhiaagarwal!

Read through the code and looks great. Really stepping up the benchmarking game here!

There are a few minor CI failures to fix, but we can merge otherwise.

One question that came up, especially considering @alexwilcoxson-rel latest PR. Is there a way we can track additional metrics we collect during query execution as benchmarking results? I.e. teacking how well we do file skipping / reading so files skipped or bytes read ...

I looked into this, and I believe not :( I believe this issue in divan would be what we're looking for nvzqz/divan#34

@rtyler rtyler enabled auto-merge (rebase) October 19, 2025 18:53
@rtyler rtyler merged commit fae52d6 into delta-io:main Oct 19, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants