fix(core): handle Result type after get_actions sync conversion #3846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed compilation errors that occurred after
get_actionswas converted from async to sync as part of #3837. The refactoring changed the function signature but left several call sites using the old async pattern, resulting in type mismatches and compilation failures across multiple modules.Changes Made
?operator to properly handleResult<Vec<Action>, DeltaTableError>returned byget_actions().awaitcalls sinceget_actionsis now synchronous and no longer returns aFuture&&ActiontoActionin filter predicates to match the updated return type structureFiles Modified
crates/core/src/kernel/transaction/conflict_checker.rs- Added?operator and fixed iterator pattern matchingcrates/core/src/operations/load_cdf.rs- Added?operator to handle Result typecrates/core/src/operations/merge/mod.rs- Removed.awaitcalls (3 locations)crates/core/src/operations/write/mod.rs- Fixed pattern matching in filter predicates (3 locations)Testing
All compilation errors have been resolved. Testing results:
cargo fmtcargo clippywith no new warningsImpact
This change addresses compilation failures without altering runtime behavior or public API surface. The modifications are minimal and focused solely on adapting call sites to the new synchronous
get_actionsfunction signature.Related Issue(s)
get_actionsasync-to-sync conversionDocumentation
No documentation changes are required as this is an internal implementation change that maintains backward compatibility in functionality while adapting to the new synchronous API.