Skip to content

Conversation

@zen-zap
Copy link

@zen-zap zen-zap commented Oct 15, 2025

Description

changed add_actions_table to return BoxStream. This helps by making sure we don't load everything into memory all at once. Added BoxStreamToReaderAdapter to convert BoxStreams to RecordBatchReader. Streaming with a specific version helps avoid race conditions but we depend on the retention period of the versions.

Related Issue(s)

None that I'm aware of.

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Oct 15, 2025
@zen-zap zen-zap marked this pull request as draft October 15, 2025 09:52
@zen-zap zen-zap marked this pull request as ready for review October 15, 2025 11:36
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.87%. Comparing base (d950bf2) to head (390df84).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/table/state.rs 0.00% 50 Missing ⚠️
crates/core/src/delta_datafusion/find_files.rs 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d950bf2) and HEAD (390df84). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d950bf2) HEAD (390df84)
8 5
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3851       +/-   ##
===========================================
- Coverage   73.77%   25.87%   -47.90%     
===========================================
  Files         151      123       -28     
  Lines       39139    19624    -19515     
  Branches    39139    19624    -19515     
===========================================
- Hits        28873     5077    -23796     
- Misses       8995    14179     +5184     
+ Partials     1271      368      -903     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rtyler rtyler marked this pull request as draft October 19, 2025 18:55
@rtyler
Copy link
Member

rtyler commented Oct 19, 2025

converting to a draft due to the conflicts

@zen-zap
Copy link
Author

zen-zap commented Oct 20, 2025

Should I try to resolve them and open it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package binding/rust Issues for the Rust crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move add_actions_table onto stream

2 participants