Skip to content

Conversation

@roeap
Copy link
Collaborator

@roeap roeap commented Oct 19, 2025

Description

This PR extends our deprecation warnings for the files and files_by_partitions methods. i.e., a warning is emitted when used, and the function is decorated with @deprecated.

We also tighten the checks in to_pyarrow_dataset to explicitly raise on tables with column mapping or deletion vectors enabled.

Beyond that, there is some code beautification - mostly line breaks in pyo3 signatures.

@roeap roeap requested a review from ion-elgreco as a code owner October 19, 2025 13:38
@github-actions github-actions bot added the binding/python Issues for the Python package label Oct 19, 2025
@roeap roeap enabled auto-merge (squash) October 19, 2025 13:39
@roeap roeap force-pushed the chore/py-deprecations branch from 6566b41 to 51c7810 Compare October 19, 2025 13:41
@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.80%. Comparing base (3583056) to head (92ccf14).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/src/reader.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3869   +/-   ##
=======================================
  Coverage   73.80%   73.80%           
=======================================
  Files         151      151           
  Lines       39161    39132   -29     
  Branches    39161    39132   -29     
=======================================
- Hits        28901    28880   -21     
+ Misses       8981     8974    -7     
+ Partials     1279     1278    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap force-pushed the chore/py-deprecations branch from 51c7810 to 8a9eda1 Compare October 19, 2025 13:44
@roeap roeap force-pushed the chore/py-deprecations branch from 8a9eda1 to 834bdc5 Compare October 19, 2025 13:46
@roeap roeap requested a review from fvaleye October 19, 2025 14:27
@roeap roeap merged commit d0ae849 into delta-io:main Oct 19, 2025
28 of 29 checks passed
@roeap roeap deleted the chore/py-deprecations branch October 19, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/python Issues for the Python package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants