Skip to content

chore: reduce wheel size #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2025
Merged

chore: reduce wheel size #3878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
559fcd0
Reduce wheel size
abhiaagarwal Oct 20, 2025
1dd61cf
Merge branch 'main' into abhi/reduce-wheel-size
rtyler Oct 21, 2025
86c0107
Merge branch 'main' into abhi/reduce-wheel-size
rtyler Oct 22, 2025
3bcfe93
Merge branch 'main' into abhi/reduce-wheel-size
rtyler Oct 24, 2025
e32d55b
Add warmup to benchmarks
abhiaagarwal Oct 25, 2025
76bc3e0
Change to opt-level 3
abhiaagarwal Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/python_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ jobs:
env:
MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
with:
maturin-version: v1.6.0 # https://github.com/PyO3/maturin/issues/2154
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha completely forgot about this pin 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the issue seemed to be resolved upstream so I removed the pin

target: x86_64-unknown-linux-gnu
command: publish
args: --skip-existing -m python/Cargo.toml
Expand Down Expand Up @@ -125,7 +124,6 @@ jobs:
env:
MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
with:
maturin-version: v1.6.0 # https://github.com/PyO3/maturin/issues/2154
target: x86_64-unknown-linux-musl
command: publish
args: --skip-existing -m python/Cargo.toml --zig
Expand Down
15 changes: 11 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ license = "Apache-2.0"
documentation = "https://docs.rs/deltalake"
repository = "https://github.com/delta-io/delta.rs"

[profile.release-with-debug]
inherits = "release"
debug = true

# Reducing the debuginfo for the test profile in order to trim the disk and RAM
# usage during development
# <https://github.com/delta-io/delta-rs/issues/1550?
Expand Down Expand Up @@ -103,10 +99,21 @@ AKS = "AKS"
# to avoid using 'type' as a field name.
tpe = "tpe"

[profile.release-with-debug]
inherits = "release"
debug = true

# for better flamegraphs when benchmarking
[profile.bench]
debug = true

[profile.profiling]
inherits = "release"
debug = true

[profile.release-python]
inherits = "release"
opt-level = 3
codegen-units = 1
lto = "fat"
strip = true
5 changes: 0 additions & 5 deletions python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,3 @@ features = [
default = ["rustls"]
native-tls = ["deltalake/s3-native-tls", "deltalake/glue"]
rustls = ["deltalake/s3", "deltalake/glue"]

[profile.release]
opt-level = 3
codegen-units = 1
lto = "fat"
1 change: 1 addition & 0 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ documentation = "https://delta-io.github.io/delta-rs/"
repository = "https://github.com/delta-io/delta-rs/tree/main/python/"

[tool.maturin]
profile = "release-python"
module-name = "deltalake._internal"

[tool.mypy]
Expand Down
8 changes: 4 additions & 4 deletions python/tests/test_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def setup() -> None:
def func(table_path: str) -> None:
write_deltalake(table_path, sample_table)

benchmark.pedantic(func, setup=setup, rounds=5)
benchmark.pedantic(func, setup=setup, rounds=5, warmup_rounds=3)

# TODO: figure out why this assert is failing
# dt = DeltaTable(str(tmp_path))
Expand Down Expand Up @@ -70,7 +70,7 @@ def setup() -> None:
def func(table_path: str) -> None:
write_deltalake(table_path, sample_table, storage_options=storage_options)

benchmark.pedantic(func, setup=setup, rounds=5)
benchmark.pedantic(func, setup=setup, rounds=5, warmup_rounds=3)


@pytest.mark.pyarrow
Expand Down Expand Up @@ -146,7 +146,7 @@ def func(dt, max_concurrent_tasks):
)

# We need to recreate the table for each benchmark run
results = benchmark.pedantic(func, setup=setup, rounds=5)
results = benchmark.pedantic(func, setup=setup, rounds=5, warmup_rounds=3)

assert results["numFilesRemoved"] == 50
assert results["numFilesAdded"] == 5
Expand Down Expand Up @@ -207,7 +207,7 @@ def func(dt, max_concurrent_tasks):
max_concurrent_tasks=max_concurrent_tasks, target_size=1024 * 1024 * 1024
)

results = benchmark.pedantic(func, setup=setup, rounds=5)
results = benchmark.pedantic(func, setup=setup, rounds=5, warmup_rounds=3)

assert results["numFilesRemoved"] == 50
assert results["numFilesAdded"] == 5
Expand Down
Loading