-
Notifications
You must be signed in to change notification settings - Fork 549
feat: extract log store into its own crate, deltalake-logstore
#3913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Abhi Agarwal <[email protected]>
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
delta-logstore
delta-logstoredeltalake-logstore
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
…rate Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
|
Timings of this branch: Timings of main: While the overall timing is the same (due to all the build targets such as tests and python still requiring (all after a cargo clean, running |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3913 +/- ##
==========================================
- Coverage 73.88% 73.77% -0.12%
==========================================
Files 152 151 -1
Lines 39426 39440 +14
Branches 39426 39440 +14
==========================================
- Hits 29131 29097 -34
- Misses 8971 9019 +48
Partials 1324 1324 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
Signed-off-by: Abhi Agarwal <[email protected]>
Description
Extracts the logstore delta lake component into its own crate, making core take a dependency on it. This allows the aws, gcp, hdfs, etc implementations to rely exclusively on
deltalake-logstoreinstead of depending on core, flipping the dependency graph and decreasing compile times (about a 30% decrease on my system).Related Issue(s)
Progress towards #3899
Documentation
Still a WIP, but compiles locally without fixing the tests (which mostly require changing changing
DeltaResulttoLogStoreResult.