Fix wheels build by removing duplicate wheels #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJin-db
force-pushed
the
fix-wheels-build
branch
from
9ca0ce1 to
7484665
Compare
chakankardb
approved these changes
Dec 20, 2024
charlenelyu-db
pushed a commit
to charlenelyu-db/delta-sharing
that referenced
this pull request
Mar 25, 2025
charlenelyu-db
added a commit
that referenced
this pull request
Mar 27, 2025
* fix * upgrade delta-kernel-rs (#607) * update expected error msg in test (#608) * rust bindings for CDF (#612) Co-authored-by: Oussama Saoudi <[email protected]> * python connector CDF reads (#613) * fix version (#616) * reference rust wrapper 0.2.0 (#617) * add table changes with use_delta_format=True example (#619) * Fix wheels build by removing duplicate wheels (#623) * update delta-kernel-rust-sharing-wrapper to 0.2.1 and fix path in workflows (#625) * update delta-kernel-rust-sharing-wrapper to 0.2.1 * fix names in build workflow * Improvement python delta-sharing client: convert expires_in as string to int, if returned as string (#628) **TL;DR:** This PR enhances the OAuth client to support cases where the expires_in field in the token response is returned as a string instead of an integer. While the OAuth 2.0 specification mandates that expires_in should be an integer [RFC 6749 Section 4.1.4](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.4), some OAuth servers return it as a string, leading to potential compatibility issues. Certain OAuth implementations deviate from the standard and return expires_in as a string, e.g.: ``` { "access_token": "example-token", "expires_in": "3600", // Returned as a string "token_type": "Bearer" } ``` This causes failures when the client expects the field to always be an integer. Solution This PR updates the token parsing logic to: 1. Check the type of the expires_in field. 2. Convert the value to an integer if it is provided as a string. 3. Maintain backward compatibility with the standard integer format. * upgrade delta-kernel-rs to 0.6.1 to fix reading tables partitioned on timestamp (#634) * include source in maturin build of delta-kernel-rust-sharing-wrapper (#647) * update latest version that does not require the rust wrapper in README (#650) * Support delta format for table protocol and metadata (#657) * timestampntz support (#654) * Fix timestampntz test (#662) * fix python lint and reformat scripts (#668) * ubuntu version * fix --------- Co-authored-by: Patrick Jin <[email protected]> Co-authored-by: Oussama Saoudi <[email protected]> Co-authored-by: Moe Derakhshani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ARM jobs for Linux and Windows were non-functional and created the same wheel as their x86 counterpart. When the final merge job runs, the existence of two identical wheel files caused the wheel in the merged zip file to potentially get corrupted. This PR fixes that issue by removing the ARM jobs for Linux and Windows.
To verify that the wheels are fixed, I re-ran the merge action 10 times, and none of the wheels in any of the runs were corrupted. In contrast, 6 out of 10 runs with the previous build workflow had at least one wheel that was corrupted. Corruption was determined by checking if the wheel files would unzip, since a wheel file is a ZIP archive under the hood.