Skip to content

Handle empty String nextPageToken correctly in DeltaSharingClient #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle empty String nextPageToken correctly in DeltaSharingClient #777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/main/scala/io/delta/sharing/client/DeltaSharingClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ class DeltaSharingRestClient(
if (response != null && response.items != null) {
shares ++= response.items
}
while (response.nextPageToken.nonEmpty) {
while (response.nextPageToken.exists(_.nonEmpty)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this?

val encodedPageToken = URLEncoder.encode(response.nextPageToken.get, "UTF-8")
val target = getTargetUrl(s"/shares?pageToken=$encodedPageToken")
response = getJson[ListSharesResponse](target)
Expand All @@ -280,7 +280,7 @@ class DeltaSharingRestClient(
if (response != null && response.items != null) {
tables ++= response.items
}
while (response.nextPageToken.nonEmpty) {
while (response.nextPageToken.exists(_.nonEmpty)) {
val encodedPageToken = URLEncoder.encode(response.nextPageToken.get, "UTF-8")
val target =
getTargetUrl(s"/shares/$encodedShareName/all-tables?pageToken=$encodedPageToken")
Expand Down