[Kernel] During Active-AddFile-Log-Replay do not pass the RemoveFile to checkpoint reader #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopj
force-pushed
the
anoopj-remove
branch
3 times, most recently
from
4a92f4e to
6d05a97
Compare
scottsand-db
requested changes
Feb 10, 2025
kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/ActionsIterator.java
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/ActionsIterator.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/ActiveAddFilesIterator.java
Show resolved
Hide resolved
anoopj
force-pushed
the
anoopj-remove
branch
from
6d05a97 to
e40da17
Compare
scottsand-db
requested changes
Feb 11, 2025
kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/ActionsIterator.java
Outdated
Show resolved
Hide resolved
…to checkpoint reader #### Which Delta project/connector is this regarding? - [ ] Spark - [ ] Standalone - [ ] Flink - [X] Kernel - [ ] Other (fill in here) ## Description Implemented a minor performance improvement to not read any RemoveFiles when we read checkpoint Parquet files during active-add-file-log-replay. Fixes delta-io#4102 ## How was this patch tested? Existing unit test, manual test using ./run-tests.py --group kernel and delta/kernel/examples/run-kernel-examples.py --use-local ## Does this PR introduce _any_ user-facing changes? No
anoopj
force-pushed
the
anoopj-remove
branch
from
e40da17 to
fbe3c3d
Compare
scottsand-db
approved these changes
Feb 11, 2025
vkorukanti
approved these changes
Feb 11, 2025
| @@ -60,7 +60,14 @@ public class ActionsIterator implements CloseableIterator<ActionWrapper> { | |||
| */ | |||
| private final LinkedList<DeltaLogFile> filesList; | |||
|
|
|||
| private final StructType readSchema; | |||
| /** Schema used for reading delta files. */ | |||
There was a problem hiding this comment.
nit: update the class docs to indicate two schemas of data.
Comment on lines
123
to
+125
| /** | ||
| * @return a tuple of (ColumnarBatch, isFromCheckpoint), where ColumnarBatch conforms to the | ||
| * instance {@link #readSchema}. | ||
| * instance {@link #deltaReadSchema}. |
There was a problem hiding this comment.
Can you update these docs to reflect that we return #checkpointReadSchema batches when isFromCheckpoint=true?
| // Step 3: Drop the RemoveFile column and use the selection vector to build a new | ||
| // FilteredColumnarBatch | ||
| ColumnarBatch scanAddFiles = addRemoveColumnarBatch.withDeletedColumnAt(1); | ||
| // For Parquet files, we would only have read the adds, not the removes, hence the check. | ||
| if (scanAddFiles.getSchema().length() > 1) { |
There was a problem hiding this comment.
This could also use isFromCheckpoint, which I maybe prefer in case in the future there's ever additional columns added or anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Implemented a minor performance improvement to not read any RemoveFiles when we read checkpoint Parquet files during active-add-file-log-replay. Fixes #4102
How was this patch tested?
Existing unit test, manual test using
delta/kernel/examples/run-kernel-examples.py --use-local
and
./run-tests.py --group kernel
Does this PR introduce any user-facing changes?
No