[Spark] Fix REPLACE
and CREATE LIKE
for CatalogOwned
#4504
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR fixes two subtle but critical parts for CatalogOwned enable table.
CREATE LIKE
, enable CatalogOwned w/ default spark configuration.CREATE LIKE
, where the source table protocol will take precedence and override any default (table feature) enablement.REPLACE
, only filter outCatalogOwnedTableFeature
if the existing table does not have CatalogOwned enabled - otherwise there would be protocol downgrade issue if we are adding new table feature (e.g.,ClusteringTableFeature
) at the same time.InCommitTimestampTableFeature
if the original table does not have ICT enabled, and users are not enabling ICT via explicit overrides or default ICT spark configuration.InCommitTimestampTableFeature
may be generated as part of the default CatalogOwned enablement, and we do not support enabling CatalogOwned throughREPLACE
.How was this patch tested?
N/A
Does this PR introduce any user-facing changes?
N/A