[WIP][Kernel][RFC] Add type change history to StructField #4512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
As part of supporting write support for type widening the kernel. We run into a similar design issue as Collation. Where type changes are stored in FieldMetadata at the nearest parent struct field, but for maps/arrays we need to construct a path separately.
This change serves as a discussion point on two questions:
StructFieldand make use of similar logic in collation to collect it up to the nearest non-map/array parent?TypeChangeclass to wrap from/to. If we want to proceed with the new member onStructFieldI will update the PR to include the new class as well.How was this patch tested?
Does this PR introduce any user-facing changes?