[Spark] Delta Connect python client implementation + tests (ported from the branch-4.0-preview) #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picks up changes from delta-io#3510
Copy mypy fixes from delta-io#4473
allisonport-db
force-pushed
the
run-python-tests-spark-master-2025-delta-connect
branch
from
c584603 to
a6e07bc
Compare
allisonport-db
force-pushed
the
run-python-tests-spark-master-2025-delta-connect
branch
from
a6e07bc to
770cce1
Compare
5 tasks
longvu-db
reviewed
May 9, 2025
python/run-tests.py
Outdated
| # TODO: In the future, find a way to get these | ||
| # packages locally instead of downloading from Maven. | ||
| delta_connect_packages = ["com.google.protobuf:protobuf-java:3.25.1", | ||
| "org.apache.spark:spark-connect_2.13:4.0.0-preview1", |
There was a problem hiding this comment.
Suggested change
| "org.apache.spark:spark-connect_2.13:4.0.0-preview1", | |
| "org.apache.spark:spark-connect_2.13:4.0.0-preview1", |
Could we change this in all places to latest RC4, like build.sbt?
There was a problem hiding this comment.
yeah also good catch
There was a problem hiding this comment.
Did not realize we manually add deps in build.sbt for specific release 🐙 updated them now
longvu-db
reviewed
May 9, 2025
setup.py
Outdated
| else: # MAJOR_VERSION >= 4 | ||
| # Delta 4.0+ contains Delta Connect code and uses Spark 4.0+ | ||
| packages_arg = ['delta', 'delta.connect', 'delta.connect.proto'] | ||
| install_requires_arg = ['pyspark>=4.0.0.dev1', 'importlib_metadata>=1.0.0'] |
There was a problem hiding this comment.
Why only dev1? Do we have the latest RC or dev2?
There was a problem hiding this comment.
Good catch, this should be 4.0.0; The CI installs 4.0.0 and not the preview but this would be the wrong requirement
allisonport-db
force-pushed
the
run-python-tests-spark-master-2025-delta-connect
branch
from
75638dd to
0bb8355
Compare
allisonport-db
added a commit
that referenced
this pull request
May 9, 2025
) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [X] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Currently we don't run our python tests for our Spark master build since there is no nightly pyspark snapshot, this PR runs those python tests using the latest RC for the Spark 4.0 release. When future RCs are released (or the release published) we will use those instead. This unblocks the Delta Connect python client development in master, which previously was only merged to the `branch-4.0-preview1` branch since we could not run the python tests in master. #4514 is based off of this one and adds the python delta connect client. ## How was this patch tested? CI tests.
longvu-db
reviewed
May 15, 2025
| pipenv run pip install protobuf==5.29.1 | ||
| pipenv run pip install googleapis-common-protos-stubs==2.2.0 | ||
| pipenv run pip install grpc-stubs==1.24.11 | ||
| pipenv run pip install https://dist.apache.org/repos/dist/dev/spark/v4.0.0-rc6-bin/pyspark-4.0.0.tar.gz |
There was a problem hiding this comment.
I changed this from rc4 to rc6 if that's okay, feel free to put it back if it's not
| def setUpClass(cls) -> None: | ||
| # Spark Connect will set SPARK_CONNECT_TESTING_REMOTE, and it does not allow MASTER | ||
| # to be set simultaneously, so we need to clear it. | ||
| if "MASTER" in os.environ: |
There was a problem hiding this comment.
Putting it here https://github.com/delta-io/delta/pull/4514/files#diff-c6a6d2ea000a5486e0b658804b04c565fc6248ba8d872246167421496251ceeaR210 doesn't work, so we will have to put it here for now
| def test_history(self): | ||
| pass | ||
|
|
||
| @unittest.skip("cdc has not been implemented yet") |
There was a problem hiding this comment.
Add test_cdc, test_addFeatureSupport and test_dropFeatureSupport, they are the latest additions of https://github.com/delta-io/delta/blob/master/python/delta/tests/test_deltatable.py
longvu-db
reviewed
May 15, 2025
| @@ -74,8 +75,15 @@ jobs: | |||
| pipenv run pip install pydocstyle==3.0.0 | |||
| pipenv run pip install pandas==2.2.0 | |||
| pipenv run pip install pyarrow==11.0.0 | |||
| pipenv run pip install numpy==1.21 | |||
| pipenv run pip install https://dist.apache.org/repos/dist/dev/spark/v4.0.0-rc4-bin/pyspark-4.0.0.tar.gz | |||
| pipenv run pip install pypandoc==1.3.3 | |||
There was a problem hiding this comment.
Not sure why we pip install 2 different versions of wheel (0.43.0 and 0.33.4), right above
longvu-db
reviewed
May 15, 2025
| # Spark Connect (required) | ||
| grpcio>=1.67.0 | ||
| grpcio-status>=1.67.0 | ||
| googleapis-common-protos>=1.65.0 |
There was a problem hiding this comment.
Suggested change
| googleapis-common-protos>=1.65.0 | |
| googleapis-common-protos>=1.65.0 | |
| protobuf==5.29.1 |
allisonport-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Based off of #4513
Adds the Delta Connect python client from
branch-4.0-preview1to master since we now are able to run our python tests using the latest Spark 4.0 RC.How was this patch tested?
Does this PR introduce any user-facing changes?