[SPARK] Handle special characters correctly in validateDataSkippingType #4531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulsmahadev
commented
May 13, 2025
| // We need to figure out if the column is top-level column | ||
| // or a column inside a struct, we support collecting null count stats | ||
| // on nested columns part of a struct. | ||
| val fieldInsideStruct = prefixPath.size > 0 |
There was a problem hiding this comment.
Fix this bug as well, we were not correctly handling nested columns in the root schema
rahulsmahadev
commented
May 13, 2025
| @@ -526,32 +526,6 @@ class StatsCollectionSuite | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| test(s"Delta statistic column: invalid data type $invalidType in nested column") { | |||
There was a problem hiding this comment.
remove this test, no longer applicable since we shouldn't throw an error https://github.com/delta-io/delta/pull/4531/files#diff-2af271647c445a4476d202c2b2a08fd22e8ea41ad1da85153812f750c52d52abL468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Fix bug in stats collection code for handling special characters in column names
How was this patch tested?
Does this PR introduce any user-facing changes?
no