Introduce WriterCompatV3 #4730
Open
Introduce WriterCompatV3 #4730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzlfred
reviewed
Jun 9, 2025
|
|
||
| /** | ||
| * Table property that enables modifying the table in accordance with the Delta-Iceberg | ||
| * Compatibility V3 protocol. |
There was a problem hiding this comment.
add a word saying compat v2 is skipped to align with iceberg spec v3
| * they are not in use. In later checks we validate that these incompatible features are inactive | ||
| * in the table. See the protocol spec for more details. | ||
| */ | ||
| private static Set<TableFeature> ALLOWED_TABLE_FEATURES = |
There was a problem hiding this comment.
plz combine the list with the refactoring and only put new v3 allowed table feature here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
abstract class IcebergWriterCompatMetadataValidatorAndUpdaterwhich is being implemented by the existingIcebergWriterCompatV1MetadataValidatorAndUpdaterand newly introducedIcebergWriterCompatV3MetadataValidatorAndUpdater.How was this patch tested?
Unit tests.
Does this PR introduce any user-facing changes?
Introduce IcebergWriterCompatV3 (jumped from v1) skipped v2 to align with IcebergCompatV3 which maps to iceberg format v3. Major changes are row tracking, DV, and new datatypes such as variant.