[Kernel][#2] Refactor WriterCompat metadata validator and updater #4734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murali-db
changed the title
murali-db
changed the title
format style issues # Conflicts: # kernel/kernel-api/src/main/java/io/delta/kernel/internal/icebergcompat/IcebergWriterCompatV1MetadataValidatorAndUpdater.java
murali-db
force-pushed
the
refactor-writer-metadata-validator
branch
from
f1808ff to
d5fd1f5
Compare
lzlfred
reviewed
Jun 11, 2025
...a/io/delta/kernel/internal/icebergcompat/IcebergWriterCompatMetadataValidatorAndUpdater.java
Outdated
Show resolved
Hide resolved
lzlfred
approved these changes
Jun 11, 2025
vkorukanti
requested changes
Jun 13, 2025
...a/io/delta/kernel/internal/icebergcompat/IcebergWriterCompatMetadataValidatorAndUpdater.java
Outdated
Show resolved
Hide resolved
| protected static IcebergCompatCheck createUnsupportedTypesCheck(String compatFeatureName) { | ||
| return (inputContext) -> { | ||
| List<Tuple2<List<String>, StructField>> matches = | ||
| SchemaUtils.filterRecursively( |
There was a problem hiding this comment.
I think @emkornfield is removing this API. Please use the SchemaIterable interface.
There was a problem hiding this comment.
Both PRs are waiting a on second reviewer before merging
...a/io/delta/kernel/internal/icebergcompat/IcebergWriterCompatMetadataValidatorAndUpdater.java
Show resolved
Hide resolved
...a/io/delta/kernel/internal/icebergcompat/IcebergWriterCompatMetadataValidatorAndUpdater.java
Outdated
Show resolved
Hide resolved
murali-db
force-pushed
the
refactor-writer-metadata-validator
branch
from
58e7723 to
8ab6280
Compare
murali-db
force-pushed
the
refactor-writer-metadata-validator
branch
from
8ab6280 to
07af1a9
Compare
vkorukanti
approved these changes
Jun 14, 2025
5 tasks
vkorukanti
pushed a commit
that referenced
this pull request
Jun 18, 2025
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [x] Kernel - [ ] Other (fill in here) ## Description <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> Follow up to #4734 and removes a missed function definition during refactoring. ## How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> Unit tests. ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. --> No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR is refactoring only, move all the validation checks from
IcebergWriterCompatV1MetadataValidatorAndUpdater.javato a new base classIcebergWriterCompatMetadataValidatorAndUpdater.javaso that later newly addedIcebergWriterCompatV3MetadataValidatorAndUpdater.javacan use them.How was this patch tested?
Existing unit tests since it is only doing refactoring.
Does this PR introduce any user-facing changes?