[Delta] Migrate DeltaLogMinorCompactionSuite to CatalogOwned
#4751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstherBear
changed the title
DeltaLogMinorCompactionSuite to CatalogOwned
EstherBear
changed the title
DeltaLogMinorCompactionSuite to CatalogOwnedDeltaLogMinorCompactionSuite to CatalogOwned
EstherBear
changed the title
DeltaLogMinorCompactionSuite to CatalogOwnedDeltaLogMinorCompactionSuite to CatalogOwned
EstherBear
force-pushed
the
migrate-delta-log-minor-compaction-suite
branch
from
be5730f to
ed05dcf
Compare
sumeet-db
approved these changes
Jun 12, 2025
xzhseh
approved these changes
Jun 12, 2025
| } | ||
|
|
||
| test("running vacuum on a catalog owned managed table should fail") { | ||
| CatalogOwnedCommitCoordinatorProvider.clearBuilders() |
There was a problem hiding this comment.
Thanks for fixing this.
^ cc @Omar-Saleh This seems to be failing non-deterministically on Delta Spark Master depending on the order of testing.
EstherBear
force-pushed
the
migrate-delta-log-minor-compaction-suite
branch
from
8f9616b to
29845e6
Compare
|
Can some explain why the test case failed even in my PR same check fails |
I've checked your pr. I think it fails because of negative scalastyle result? |
|
@EstherBear Actually my pr it is failing due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR migrates DeltaLogMinorCompactionSuite to CatalogOwned.
How was this patch tested?
Existing UTs.
Does this PR introduce any user-facing changes?
No