[Spark][ICT] Bug Fix: Avoid accidentally dropping enablement info during REPLACE on ICT tables #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharjain09
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR fixes ICT so that we don't end up accidentally dropping enablement info (ICT enablement timestamp and version) when REPLACE is run on an ICT table.
Note that this PR does not change the behaviour of when ICT remains enabled/disabled after a REPLACE. It just makes sure that if ICT remains enabled, we don't drop the enablement info.
How was this patch tested?
New tests in InCommitTimestampSuite.
Does this PR introduce any user-facing changes?
No