[Kernel] [UC] UC Commit Metrics #5362
Draft
+394
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
commented
Oct 17, 2025
| * <p>Collects timing metrics for commit operations and generates reports for successful and failed | ||
| * commits. | ||
| */ | ||
| public class UcCommitTelemetry { |
There was a problem hiding this comment.
My goal here is to be VERY succint -- I want the metrics collection and metrics result and the overall report to succinctly be in one class
scottsand-db
changed the title
scottsand-db
commented
Oct 17, 2025
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| public <T, E extends Exception> T timeChecked(ThrowingSupplier<T, E> operation) throws E { |
There was a problem hiding this comment.
I want to be able to time a method that throws a checked exception E, without having to catch the aprent Exception type. See:
scottsand-db
force-pushed
the
stack/kernel_uc_committer_metrics
branch
from
93bb691 to
867bc5d
Compare
kernel/kernel-api/src/main/java/io/delta/kernel/internal/metrics/Timer.java
Outdated
Show resolved
Hide resolved
scottsand-db
commented
Oct 20, 2025
There was a problem hiding this comment.
TODO -- Json Serialization tests
scottsand-db
requested review from
allisonport-db,
huan233usc and
raveeram-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?