Add null-check in coersion tree for tostring, to disregard real nulls #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue?
For one of our kafka topics (Azure Eventhub) we receive a payload where data can be delivered as
{"attribute": null}. Kafka delta ingest currently treats this as"null", when it is an attribute candidate for a string type column.Why does this happen?
In the coercion tree, this is implicitly cast to a string when the target column for this attribute is of string type.
The logic does not check for nulls, and assumes that a proper null is the string value. This is technically wrong.
Fixed that by explicitly disregard nulls in this coercion.
Result
We simulated a test where two payloads were sent frequently, one with a proper string, one with a null value.
Here you see the effect post-change, where nulls are now treated as a proper null.