Skip to content

change notification to react-toast-notification #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bestinbthomas
Copy link
Member

No description provided.

@bestinbthomas bestinbthomas force-pushed the custom-notification branch 2 times, most recently from 74cc16d to e7572e3 Compare February 14, 2020 19:36
@bestinbthomas bestinbthomas changed the title change notification to toastr change notification to react-toast-notification Feb 14, 2020
@kumaran-14 kumaran-14 force-pushed the custom-notification branch 3 times, most recently from 850373e to e96b55c Compare February 16, 2020 13:56
@kumaran-14
Copy link
Collaborator

@shb9019

First off, there seems to be no enum for socket events and possible notifications. We should add them.
Secondly, Look into the Notification actions. Since the notification trigger logic is shifted to the useEffect method in the component, there seems to be few redundant actions. Should we keep them?

Also, review the pr and look into the dispatch sagas being called. Is the current way of calling them okay?

Minor stuff: The notifications in redux state is simply an array [], not an array of specific type. We should pick a data format and stick to it.

// @ts-ignore
(notification) => notification.type !== action.payload.type,
);

Copy link
Collaborator

@kumaran-14 kumaran-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bestinbthomas We may need to work on this a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants