-
Notifications
You must be signed in to change notification settings - Fork 1
change notification to react-toast-notification #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
74cc16d
to
e7572e3
Compare
e7572e3
to
cfd6054
Compare
850373e
to
e96b55c
Compare
- Ignore variable-name rule for functional sockethandler component
e96b55c
to
0dd0421
Compare
First off, there seems to be no enum for socket events and possible notifications. We should add them. Also, review the pr and look into the dispatch sagas being called. Is the current way of calling them okay? Minor stuff: The notifications in redux state is simply an array codecharacter-web/src/app/reducers/Notification.ts Lines 31 to 33 in 0dd0421
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bestinbthomas We may need to work on this a bit more.
No description provided.