Skip to content

doc: simplify the doc#119

Merged
NicolasCARPi merged 3 commits into
masterfrom
nico/260514-doc
May 15, 2026
Merged

doc: simplify the doc#119
NicolasCARPi merged 3 commits into
masterfrom
nico/260514-doc

Conversation

@NicolasCARPi
Copy link
Copy Markdown
Member

@NicolasCARPi NicolasCARPi commented May 14, 2026

@eltouma the thing about air and live reload is missing, I'll let you complete it.

Summary by CodeRabbit

  • Documentation
    • Expanded contributor guide with a full local development walkthrough: OAuth/ORCID setup, local HTTPS reverse-proxy, .env template, docker-compose startup, database initialization, and updated local server port to 8080
    • Replaced Quick Start in the project README with a comprehensive configuration guide (environment variables, DB, S3, auth)
    • Removed obsolete standalone installation and configuration docs and consolidated guidance into primary references

Review Change Stack

@NicolasCARPi NicolasCARPi requested a review from eltouma May 14, 2026 07:29
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Warning

Rate limit exceeded

@NicolasCARPi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 27 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c7375602-d4fa-4998-8d15-11c384923d09

📥 Commits

Reviewing files that changed from the base of the PR and between 2808242 and adbbb77.

📒 Files selected for processing (3)
  • CLI_README.md
  • CONTRIBUTING.md
  • Makefile
📝 Walkthrough

Walkthrough

Consolidates configuration and setup docs: configuration tables moved into README.md; full local-development walkthrough (ORCID, nginx mkcert, docker-compose, .env, DB init) added to CONTRIBUTING.md; default local port changed from 8090 to 8080.

Changes

Documentation Consolidation

Layer / File(s) Summary
Configuration documentation into README
README.md, docs/configuration.md
Quick Start replaced by a Configuration Guide in README.md documenting environment variables for core settings, PostgreSQL, S3 storage, and ORCID; prior docs/configuration.md content removed.
Setup and startup documentation into CONTRIBUTING
CONTRIBUTING.md, docs/installation.md, nginx/README.md
Adds full local-development walkthrough in CONTRIBUTING.md: ORCID OAuth setup, nginx mkcert reverse-proxy, docker-compose.yml startup for postgres+nginx, a .env template, DB init commands (db migrate up, db seed, admin add), and updated server start using source .env and port 8080; prior docs/installation.md and nginx/README.md content removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibbled through docs, then hopped them in line,
README holds config, CONTRIBUTING shines.
Ports set to eight-oh-eight-oh, neat and spry,
A dev's little burrow, cozy and dry.
Hooray for tidy paths beneath the sky!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'doc: simplify the doc' is vague and generic, using non-descriptive terms that don't convey meaningful information about the changeset. Provide a more specific title that describes the actual restructuring, such as 'doc: consolidate configuration and installation guides into CONTRIBUTING.md' or 'doc: reorganize documentation by moving setup content to CONTRIBUTING.md'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nico/260514-doc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
@NicolasCARPi NicolasCARPi requested a review from eltouma May 15, 2026 11:02
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

♻️ Duplicate comments (1)
CONTRIBUTING.md (1)

88-88: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Clarify DEV_MODE behavior.

The explanation states that DEV_MODE=1 makes the program serve .html files directly instead of embedding them. However, a past review noted that .html files are not embedded in dev mode and there is no index.html file in the repo.

#!/bin/bash
# Description: Verify if .html files exist and check embed logic

# Check for .html files in the repo
fd -e html

# Check how DEV_MODE affects file serving in the Go code
rg -nP --type=go -C5 'DEV_MODE|embed'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CONTRIBUTING.md` at line 88, Update the CONTRIBUTING.md description of
DEV_MODE to accurately state that setting DEV_MODE=1 causes the app to serve
static files from disk rather than using embedded assets (i.e., HTML files are
not embedded in dev mode), and explicitly note that there is no index.html in
the repository so developers should not expect a prebuilt index to be served;
edit the paragraph that mentions DEV_MODE and "embedding" to replace the current
wording with this precise behavior and a brief note about where to place or
generate HTML during development.
🧹 Nitpick comments (3)
README.md (1)

63-70: ⚡ Quick win

Expand S3 Storage Setup to mention S3-compatible alternatives.

The section only mentions AWS S3, but line 65 states "The application supports any S3-compatible storage service." Consider adding brief examples of alternatives like MinIO, Scaleway Object Storage, or DigitalOcean Spaces to help developers understand the full range of options.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 63 - 70, Update the "S3 Storage Setup" section to
explicitly list S3-compatible alternatives and brief setup notes: expand the
"AWS S3" subsection to keep the existing AWS steps and add short subsections or
bullet points for examples like "MinIO", "DigitalOcean Spaces", and "Scaleway
Object Storage", each noting any provider-specific tips (e.g., endpoint override
for MinIO, region/endpoint details for Spaces/Scaleway) and reminding users to
provide access key/secret and bucket name in the same configuration format used
by the app; reference the "S3 Storage Setup" header and the existing "AWS S3"
bullets so maintainers can locate and extend the content consistently.
CONTRIBUTING.md (2)

93-97: 💤 Low value

Code fence style inconsistency.

The code block uses backticks, but the document uses tildes for other code fences. For consistency, switch to tildes.

🎨 Proposed fix
-```bash
+~~~bash
 source .env
 go run src/*.go --dir files
 # use --port option to run on another port than the default
-```
+~~~
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CONTRIBUTING.md` around lines 93 - 97, Replace the triple-backtick fenced
code block containing the bash snippet (the block that starts with "source .env"
and includes "go run src/*.go --dir files" and the comment about --port) with a
triple-tilde fenced block using the same language tag ("bash"); update both the
opening and closing fences so the block style matches the rest of the document
and preserves the language marker and content.

113-113: ⚡ Quick win

Fix heading level increment.

The heading jumps from h1 (#) to h3 (###). Use h2 (##) for "Local Development Build" to maintain proper heading hierarchy.

📝 Proposed fix
-### Local Development Build
+## Local Development Build
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CONTRIBUTING.md` at line 113, Change the "Local Development Build" heading
from level 3 (### Local Development Build) to level 2 (## Local Development
Build) so the document maintains proper heading hierarchy; update the single
heading text "Local Development Build" accordingly in CONTRIBUTING.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CONTRIBUTING.md`:
- Line 57: The shell example contains a faulty command "cp
docker-compose.yml.dist" missing the destination; update that command in
CONTRIBUTING.md so the cp invocation includes the destination filename (e.g.,
copy the .dist file to docker-compose.yml) so the command correctly performs the
copy.

In `@README.md`:
- Line 38: Update the README line describing DEV_MODE to clarify that DEV_MODE
(env var DEV_MODE) enables development features like disk-based file serving and
detailed errors but does not itself provide hot reload; explicitly state that
hot reload is provided by Air (configured via .air.toml) and is started when
running the local development target (e.g., make local). Mention both roles:
DEV_MODE is a prerequisite for live-reload-friendly behavior, and Air (or
running make local) is required for automatic restarts on file changes.

---

Duplicate comments:
In `@CONTRIBUTING.md`:
- Line 88: Update the CONTRIBUTING.md description of DEV_MODE to accurately
state that setting DEV_MODE=1 causes the app to serve static files from disk
rather than using embedded assets (i.e., HTML files are not embedded in dev
mode), and explicitly note that there is no index.html in the repository so
developers should not expect a prebuilt index to be served; edit the paragraph
that mentions DEV_MODE and "embedding" to replace the current wording with this
precise behavior and a brief note about where to place or generate HTML during
development.

---

Nitpick comments:
In `@CONTRIBUTING.md`:
- Around line 93-97: Replace the triple-backtick fenced code block containing
the bash snippet (the block that starts with "source .env" and includes "go run
src/*.go --dir files" and the comment about --port) with a triple-tilde fenced
block using the same language tag ("bash"); update both the opening and closing
fences so the block style matches the rest of the document and preserves the
language marker and content.
- Line 113: Change the "Local Development Build" heading from level 3 (### Local
Development Build) to level 2 (## Local Development Build) so the document
maintains proper heading hierarchy; update the single heading text "Local
Development Build" accordingly in CONTRIBUTING.md.

In `@README.md`:
- Around line 63-70: Update the "S3 Storage Setup" section to explicitly list
S3-compatible alternatives and brief setup notes: expand the "AWS S3" subsection
to keep the existing AWS steps and add short subsections or bullet points for
examples like "MinIO", "DigitalOcean Spaces", and "Scaleway Object Storage",
each noting any provider-specific tips (e.g., endpoint override for MinIO,
region/endpoint details for Spaces/Scaleway) and reminding users to provide
access key/secret and bucket name in the same configuration format used by the
app; reference the "S3 Storage Setup" header and the existing "AWS S3" bullets
so maintainers can locate and extend the content consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b1c91994-6280-4e91-9d76-4de01524dec1

📥 Commits

Reviewing files that changed from the base of the PR and between 8774bf5 and 2808242.

📒 Files selected for processing (5)
  • CONTRIBUTING.md
  • README.md
  • docs/configuration.md
  • docs/installation.md
  • nginx/README.md
💤 Files with no reviewable changes (3)
  • docs/installation.md
  • docs/configuration.md
  • nginx/README.md

Comment thread CONTRIBUTING.md Outdated
Comment thread README.md
Comment thread CONTRIBUTING.md
@NicolasCARPi NicolasCARPi merged commit 954b5b3 into master May 15, 2026
3 checks passed
@NicolasCARPi NicolasCARPi deleted the nico/260514-doc branch May 15, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants