Skip to content

fix/minor: replace backend IP with Docker service hostname#96

Merged
NicolasCARPi merged 2 commits into
masterfrom
elsa-260401-nginx-conf
Apr 1, 2026
Merged

fix/minor: replace backend IP with Docker service hostname#96
NicolasCARPi merged 2 commits into
masterfrom
elsa-260401-nginx-conf

Conversation

@eltouma
Copy link
Copy Markdown
Collaborator

@eltouma eltouma commented Apr 1, 2026

Summary by CodeRabbit

  • Chores
    • Updated application infrastructure configuration to use DNS-based backend service discovery, replacing hardcoded network addressing with dynamic hostname resolution for improved deployment flexibility.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2026

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 1ec02983-2a7c-4308-aa6a-7bc3ae432dca

📥 Commits

Reviewing files that changed from the base of the PR and between 720832b and 1ee2291.

📒 Files selected for processing (2)
  • nginx.conf
  • nginx/nginx.conf
💤 Files with no reviewable changes (1)
  • nginx.conf
🚧 Files skipped from review as they are similar to previous changes (1)
  • nginx/nginx.conf

📝 Walkthrough

Walkthrough

Deleted the top-level nginx.conf and updated nginx/nginx.conf upstream backend from 192.168.0.102:8080 to eln-community-dev:8080 (comment added). The removed top-level config included the TLS reverse-proxy and proxy header settings; the nested config kept proxying logic with the new hostname.

Changes

Cohort / File(s) Summary
Removed top-level config
nginx.conf
Deleted file containing global Nginx process/event settings and an HTTPS reverse-proxy server (TLS, proxy headers, and routing to app_backend)
Nested Nginx config updated
nginx/nginx.conf
Changed upstream app_backend target from server 192.168.0.102:8080; to server eln-community-dev:8080; and added a comment (# name of container). Proxy/server blocks remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I swapped the numbers for a name so spry,
DNS now guides where requests may fly.
One file removed, one host set free,
Hopping through packets, happy as can be! 🥕✨


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

* add comment into /nginx/nginx.conf
@NicolasCARPi NicolasCARPi merged commit cfaccc8 into master Apr 1, 2026
3 checks passed
@NicolasCARPi NicolasCARPi deleted the elsa-260401-nginx-conf branch April 1, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants