Skip to content

fix: prefer user-facing camera#94

Open
WofWca wants to merge 1 commit into
mainfrom
wofwca/19aa06e989
Open

fix: prefer user-facing camera#94
WofWca wants to merge 1 commit into
mainfrom
wofwca/19aa06e989

Conversation

@WofWca

@WofWca WofWca commented Jun 16, 2026

Copy link
Copy Markdown
Member

@WofWca
WofWca requested a review from lk108 June 16, 2026 09:35
@WofWca
WofWca force-pushed the wofwca/19aa06e989 branch from 998ca04 to 2ea3bfd Compare June 16, 2026 09:37
@WofWca

WofWca commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

I have tested this with pnpm start. Still works on my machine.

@lk108

lk108 commented Jun 16, 2026

Copy link
Copy Markdown

Works for me as well. Let me try to organize a test on a device that has the issue of auto-selecting the wrong camera (I don't own one of these).

@WofWca

WofWca commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

I think we can do a release with this if you don't have a dev setup.

@lk108

lk108 commented Jun 16, 2026

Copy link
Copy Markdown

Maybe there's a misunderstanding? I build calls-webapp with your changes, and it works on my device. It's already included in a DeltaTouch PR. The issue of the wrong camera being selected was reported by two users of a specific phone model which I don't own myself, so I am now in the process of asking them to test the DeltaTouch PR that includes your changes in calls-webapp.

@WofWca

WofWca commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Great! I just thought that you'd need a calls-webapp release to be able to test it with UT.

@lk108

lk108 commented Jun 16, 2026

Copy link
Copy Markdown

Unfortunately, the user reports that the issue is not fixed by this PR: https://codeberg.org/lk108/deltatouch/issues/270#issuecomment-17575496

@lk108 lk108 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but seems like it doesn't solve the original problem of the wrong camera selected on a specific mobile phone (FLX1s). I don't feel confident enough in my JS/Webdev skills to give any recommendation to merge or not.

@WofWca

WofWca commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

Oh well... Then I guess not much can help here except #69.

Still I think this MR is worth it, on devices where the facingMode actually does something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants