Improve QR code visibility#3040
Open
mikovskii wants to merge 3 commits into
Open
Conversation
- temporarily raise screen brightness while QR codes are visible - restore the previous brightness when leaving the screen or app backgrounds - generate backup QR images from the QR payload instead of using provider SVG - remove the unused backup QR SVG wrapper
mikovskii
marked this pull request as ready for review
March 4, 2026 17:50
Collaborator
|
I am a bit hesitant to merge this right now because I feel like it would be much nicer if we could use EDR just on the QR view, instead of needing to keep track of viewWillAppear/viewWillDisappear. I haven't tested if that even produces a similar brightness but seems like it does: https://github.com/tsuzukihashi/EDR_Swift |
Contributor
Author
|
I'll test it out and try to implement it using an ERD. I looked at how it's implemented in Signal and Telegram. They use an approach similar to mine. But I'll still give the ERD a try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QR codes are now easier to scan because the app temporarily turns the screen brightness up while they are shown, then restores the previous brightness when you leave the screen or the app goes to the background.
This also updates backup QR rendering ( #2989 )
demo ( for new qr backup):
Details
close: #2989