Skip to content

Add Chinese (Simplified) Translation#59

Open
monstorix wants to merge 2 commits into
deltachat:mainfrom
monstorix:main
Open

Add Chinese (Simplified) Translation#59
monstorix wants to merge 2 commits into
deltachat:mainfrom
monstorix:main

Conversation

@monstorix

Copy link
Copy Markdown

No description provided.

@WofWca WofWca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment the code looks OK.
I didn't check the translation itself.

Comment thread i18n/zh-Hans.js Outdated
@72374

72374 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

It is necessary to add <script src="./i18n/zh-Hans.js"></script> to index.html, after these:

invite/index.html

Lines 23 to 26 in 9064fe9

<script src="./i18n/de.js"></script>
<script src="./i18n/en.js"></script>
<script src="./i18n/fr.js"></script>
<script src="./i18n/ru.js"></script>

Otherwise, the translation will not be used.

Fix the language quote

Co-authored-by: WofWca <wofwca@protonmail.com>

Add zh-Hans.js script ref in index.html
@72374

72374 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

With 'zh-Hans', the translation was not used by Firefox 140 ESR and Ungoogled Chromium 149, while "Chinese - China" / "Chinese (Simplified)" were chosen as the most preferred language.

With 'zh-CN', the translation was used; but not if "Chinese" was chosen, which required zh.

So it seems to be necessary to change 'zh-Hans' to 'zh-CN'.

It may also make sense to add a copy of the translation, but with zh, considering that this is the most common form of Chinese (if what i remember is correct).

@monstorix

Copy link
Copy Markdown
Author

So it seems to be necessary to change 'zh-Hans' to 'zh-CN'.

It may also make sense to add a copy of the translation, but with zh, considering that this is the most common form of Chinese (if what i remember is correct).

@72374 I will change the language code later.

You're right about the Chinese forms: Simplified characters are mostly used in China mainland and Singapore, which have the largest Chinese-speaking populations, while regions such as Hong Kong, Macau and Taiwan use traditional characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants