[Core] Refactor new features support check#482
Open
DjLegolas wants to merge 1 commit intodeluge-torrent:developfrom
Open
[Core] Refactor new features support check#482DjLegolas wants to merge 1 commit intodeluge-torrent:developfrom
DjLegolas wants to merge 1 commit intodeluge-torrent:developfrom
Conversation
In 1989d0d a check for a daemon version was added. As this depends on knowing the version in which the feature will be merged, this approach is not suitable for this. Therefore, a features enum will help us list all features, without knowing in which version each was added.
DjLegolas
force-pushed
the
Feature/daemon-feature-flag
branch
from
ededaea to
02f47d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1989d0d a check for a daemon version was added. As this depends on knowing the version in which the feature will be merged, this approach is not suitable for this.
Therefore, a features enum will help us list all features, without knowing in which version each was added.