Cleanup type annotations and linting for Authmanager#487
Open
adenwuts wants to merge 3 commits intodeluge-torrent:developfrom
Open
Cleanup type annotations and linting for Authmanager#487adenwuts wants to merge 3 commits intodeluge-torrent:developfrom
adenwuts wants to merge 3 commits intodeluge-torrent:developfrom
Conversation
Author
|
Tested with wrong Python version 😢 |
Author
|
tests now passing using |
flound1129
added a commit
to flound1129/deluge
that referenced
this pull request
Feb 21, 2026
…nd common Applies type annotations from upstream PR deluge-torrent#487: - Account: annotate __init__ params/fields, data() and __repr__ return types - AuthManager: annotate all method signatures and __auth dict type - configmanager.get_config_dir and common.get_default_config_dir signatures - common.create_localclient_account return type - Join multi-line log strings for clarity - Assign discarded return values to _ to satisfy type checkers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds better type annotations to authmanager for easier extension/development/maintenance. Also cleaned up a few implicit string concatenations used in logging and added override flags where appropriate.
Hoping to use this as a basis for integrating an automated upgrade path for plaintext passwords-->hashes as disccussed in #484.
No functional changes, all tests still passing.