Skip to content

Comments

Fix security tests#492

Open
ademuri wants to merge 3 commits intodeluge-torrent:developfrom
ademuri:security-tests
Open

Fix security tests#492
ademuri wants to merge 3 commits intodeluge-torrent:developfrom
ademuri:security-tests

Conversation

@ademuri
Copy link

@ademuri ademuri commented Feb 2, 2026

This makes a few changes to the security tests:

  1. Adds a fixture to clone the testssl.sh repo if it is not present
  2. Updates the CI config to cache the testssl.sh repo
  3. Updates the tests to stream output from testssl.sh, to make debugging easier/faster
  4. Filters out some noise from the SSL test results
  5. Fixes the flag for the RC4 check
  6. Updates the documentation to specify how to run these tests, and that they are skipped by default

security_test to trigger the security tests

- Added a pytest fixture to automatically clone testssl.sh if missing.
- Updated security tests to use the dynamically located testssl.sh binary.
- Added testssl_repo to .gitignore to prevent tracking the cloned dependency.
- Restored PrintingProcessProtocol for real-time output streaming.
- Replaced the manual wget/tar extraction of testssl.sh with actions/cache.
- The Python test fixture will now use the cached repository if present, or clone it if not, creating the cache for future runs.
- Cache key 'testssl-repo-v1' is used.
- Added instructions on how to run security tests locally.
- Explained the automated testssl.sh dependency management.
- Noted the CI trigger condition (including 'security_test' in commit/PR).
@ademuri ademuri marked this pull request as ready for review February 2, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant